Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process all supported JavaScript extensions by default #584

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Process all supported JavaScript extensions by default #584

merged 1 commit into from
Feb 22, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Feb 21, 2024

Description

Fixes: #582

Testing

Before

The ts files are not processed by default

$ ../jscodeshift/bin/jscodeshift.js example.ts 2>&1 | head -n 1
No files selected, nothing to do.

The extensions had to be explicitly passed

$ ../jscodeshift/bin/jscodeshift.js --extensions=ts example.ts 2>&1 | head -n 1
Processing 1 files...

By default, the extensions is set to js

$ ../jscodeshift/bin/jscodeshift.js --help | grep -A 1 extensions
      --extensions=EXT          transform files with these file extensions (comma separated list)
                                (default: js)

After

The ts files are processed without requiring to pass extensions

$ ../jscodeshift/bin/jscodeshift.js example.ts 2>&1 | head -n 1
Processing 1 files...

The ts files are skipped if extensions do not allow it

$ ../jscodeshift/bin/jscodeshift.js --extensions=js example.ts 2>&1 | head -n 1
No files selected, nothing to do.

The ts files are processed if extensions allow it

$ ../jscodeshift/bin/jscodeshift.js --extensions=ts example.ts 2>&1 | head -n 1
Processing 1 files...

By default, the extensions include all supported JavaScript/TypeScript files

$ ../jscodeshift/bin/jscodeshift.js --help | grep -A 1 extensions
      --extensions=EXT          transform files with these file extensions (comma separated list)
                                (default: cjs,es,es6,js,jsx,mjs,ts,tsx)

@trivikr trivikr mentioned this pull request Feb 21, 2024
Closed
@trivikr trivikr marked this pull request as ready for review February 21, 2024 01:41
@trivikr trivikr mentioned this pull request Feb 21, 2024
Closed
Daniel15
Daniel15 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@Daniel15 Daniel15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Daniel15 Daniel15 merged commit 6869004 into facebook:main Feb 22, 2024
4 checks passed
@Daniel15
Copy link
Member

I'll try publish this by the end of the week.

@trivikr trivikr deleted the extensions-default-supported branch February 22, 2024 00:48
@Daniel15
Copy link
Member

Daniel15 commented Feb 22, 2024 •
edited
Loading

Published as 0.15.2. Thanks for your contribution!

@Josh-Walker-GM Josh-Walker-GM mentioned this pull request Jul 22, 2024
Merged
Josh-Walker-GM added a commit to redwoodjs/redwood that referenced this pull request Jul 22, 2024
@Josh-Walker-GM @renovate
fix(deps): update dependency jscodeshift to v0.16.1 (#11051)
d86f0a9 
See: #11019.

The config used for jscodeshift used to specify a specific extension of
`js` but this now causes problems. Some of our code uses temporary
target files with no extension.

After facebook/jscodeshift#584 jscodeshift
handles a set of default extensions anyway which cover all our current
usage.

I have therefore removed the specific config and let jscodeshift do it's
default behaviour.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel15 Daniel15 Daniel15 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [email protected] ignores the files not starting with .js extension by default
3 participants
@trivikr @Daniel15 @facebook-github-bot